Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semisimple -> simple in symmetry reduction #308

Merged
merged 11 commits into from
Jun 28, 2023
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 26, 2023

First step of #302

Closes #307
Closes #306
Closes #305
Closes #304
Closes #303

@blegat blegat mentioned this pull request Jun 26, 2023
6 tasks
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 88.50% and project coverage change: +3.77 🎉

Comparison is base (8476c96) 80.11% compared to head (15066a1) 83.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   80.11%   83.89%   +3.77%     
==========================================
  Files          41       41              
  Lines        2112     2179      +67     
==========================================
+ Hits         1692     1828     +136     
+ Misses        420      351      -69     
Impacted Files Coverage Δ
src/Certificate/Symmetry/block_diag.jl 90.72% <88.50%> (+90.72%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blegat blegat merged commit 2471d5c into master Jun 28, 2023
@odow odow deleted the bl/dihedral_fix branch June 18, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant