Fixed: Export Button Logic Differentiation #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaiJiangJie
reviewed
Feb 7, 2025
| */ | ||
| return Object.assign({}, this.exportOptions, { url: this.tableUrl }) | ||
| return Object.assign(this.exportOptions, { url: this.tableUrl }) | ||
| } | ||
| }, | ||
| methods: { |
There was a problem hiding this comment.
The provided code seems to define a Vue component that exports an asset account list page. The method exportOptions has been updated from using the partialRight function incorrectly with assignIfNot and reusing it with Object.assign instead.
The main issue is related to URL assignment when navigating assets lists between nodes or after exporting. Currently, if there's no explicit change on navigation or export options, subsequent calls to /accounts/account-secrets/ will not lead to different URLs. This needs modification according to the current scenario:
- After successfully switching back to the tree view mode (account details), you may want to adjust how exported URLs are determined based on the user interaction. For instance:
exportDefaultMethods() { this.importTreeNode(false);
In general, these issues should be addressed to ensure consistent behavior across both views while also improving error handling for invalid or unexpected behaviors.
feng626
approved these changes
Feb 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.