Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -58,25 +58,25 @@ hatch-pin-jumpstarter = { workspace = true }

[dependency-groups]
docs = [
"sphinx<8.1.0",
"sphinx<9.2.0",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] The ruff version in .pre-commit-config.yaml is pinned at v0.9.2, while this file pins ruff==0.15.12. That means pre-commit run ruff uses 0.9.2, but direct ruff check uses 0.15.12, producing inconsistent lint results. .pre-commit-config.yaml should be updated to rev: v0.15.12 to match.

AI-generated, human reviewed

Comment on lines 60 to +61
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] The constraint sphinx<9.2.0 permits sphinx 9.1.x, which drops Python 3.11 support. Since all packages in this monorepo declare requires-python = ">=3.11", a future uv lock could resolve to an incompatible sphinx version. Consider tightening to sphinx>=8.0,<9.1.0, or raise the project minimum to Python 3.12.

AI-generated, human reviewed

"myst-parser>=5.0.0",
"sphinxcontrib-mermaid>=2.0.1",
"furo>=2024.8.6",
"esbonio>=0.16.4",
"sphinx-autobuild>=2024.4.16",
"sphinx-click>=6.0.0",
"sphinx-substitution-extensions>=2024.10.17",
"requests>=2.33.1",
"sphinxcontrib-mermaid>=2.0.2",
"furo>=2025.12.19",
"esbonio>=2.0.0",
"sphinx-autobuild>=2025.8.25",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] esbonio jumps from 0.16.x to >=2.0.0, skipping the entire 1.x series. This is a major breaking change that redesigned its CLI and language server protocol. The lock file still resolves to 0.16.5, so the update hasn't taken effect yet. Worth verifying that editor integrations and CI scripts that invoke esbonio still work with 2.0.0.

AI-generated, human reviewed

"sphinx-click>=6.2.0",
"sphinx-substitution-extensions>=2026.1.12",
"requests>=2.34.0",
"sphinxcontrib-programoutput>=0.19",
"sphinx-copybutton>=0.5.2",
"sphinx-inline-tabs>=2023.4.21",
"sphinx-inline-tabs>=2025.12.21.14",
]
dev = [
"ruff==0.15.10",
"typos>=1.23.6",
"pre-commit>=3.8.0",
"esbonio>=0.16.5",
"ty>=0.0.1a8",
"ruff==0.15.12",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] The lock file (python/uv.lock) is tracked in git but was not updated in this PR. Verified resolved versions: ruff=0.15.10 (wants 0.15.12), esbonio=0.16.5 (wants >=2.0.0), ty=0.0.1a11 (wants >=0.0.35). The dependency constraint changes have no practical effect until the lock file is regenerated with uv lock.

AI-generated, human reviewed

"typos>=1.46.1",
"pre-commit>=4.6.0",
"esbonio>=2.0.0",
"ty>=0.0.35",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] ty goes from alpha (0.0.1a8) to 0.0.35, spanning many releases of a rapidly evolving type checker. The lock file still resolves to 0.0.1a11. This jump may introduce new type errors once the lock file is regenerated. Running make pkg-ty-* targets against the updated version would help confirm nothing breaks.

AI-generated, human reviewed

"diff-cover>=10.2.0",
]

Expand Down
Loading