Merge pull request #37 from eduardoscottini/fix-translate-errors

Fix translate errors

lib/middlewares/translate_errors.ex

@@ -161,10 +161,14 @@ defmodule Crudry.Middlewares.TranslateErrors do
   defp message_to_string(key, value, translator, locale) when is_list(value) do
     value
     |> Enum.reject(fn x -> x == %{} end)
-    |> Enum.map(fn x ->
-      Enum.map(x, fn {inner_key, inner_value} ->
-        message_to_string(key, Map.new([{inner_key, inner_value}]), translator, locale)
-      end)
+    |> Enum.map(fn
+      string when is_binary(string) ->
+        message_to_string(key, [string], translator, locale)
+
+      enumerable when is_list(enumerable) or is_map(enumerable) ->
+        Enum.map(enumerable, fn {inner_key, inner_value} ->
+          message_to_string(key, Map.new([{inner_key, inner_value}]), translator, locale)
+        end)
     end)
   end
 

priv/repo/migrations/20190116115123_create_tables.exs

@@ -11,6 +11,7 @@ defmodule Crudry.Repo.Migrations.CreateTables do
     create table(:users) do
       add :username, :string
       add :age, :integer
+      add :password, :string
       add :company_id, references(:companies)
 
       timestamps()

test/middlewares/translate_errors_test.exs

@@ -30,6 +30,14 @@ defmodule TranslateErrorsTest do
              build_resolution("username should be at least 2 character(s)")
   end
 
+  test "translate multiple changeset errors that belongs to only one field" do
+    changeset = User.changeset(%User{}, %{username: "username", password: "a"})
+    resolution = build_resolution(changeset)
+
+    assert TranslateErrors.call(resolution, :_) ==
+    build_resolution(["password must contain an upper-case letter", "password must contain a number", "password should be at least 8 character(s)"])
+  end
+
   test "translate validate_number changeset error" do
     changeset = User.changeset(%User{}, %{username: "name", age: -5})
     resolution = build_resolution(changeset)

test/support/user.ex

@@ -5,6 +5,7 @@ defmodule Crudry.User do
   schema "users" do
     field(:username, :string)
     field(:age, :integer)
+    field(:password, :string)
 
     belongs_to(:company, Crudry.Company)
     has_many(:posts, Crudry.Post)
@@ -34,9 +35,13 @@ defmodule Crudry.User do
 
   defp base_changeset(user, attrs) do
     user
-    |> cast(attrs, [:username, :age, :company_id])
+    |> cast(attrs, [:username, :age, :password, :company_id])
     |> validate_required([:username])
     |> validate_length(:username, min: 2)
     |> validate_number(:age, greater_than: 0)
+    |> validate_length(:password, min: 8)
+    |> validate_format(:password, ~r/[0-9]+/, message: "must contain a number")
+    |> validate_format(:password, ~r/[A-Z]+/, message: "must contain an upper-case letter")
+    |> validate_format(:password, ~r/[a-z]+/, message: "must contain a lower-case letter")
   end
 end