resolve temporary constraint exclude of errorprone("com.google.guava:guava")

[Pankraz76]

---

I hereby agree to the terms of the JUnit Contributor License Agreement.

---

Definition of Done

• There are no TODOs left in the code
• Method preconditions are checked and documented in the method's Javadoc
• Coding conventions (e.g. for logging) have been followed
• Change is covered by automated tests including corner cases, errors, and exception handling
• Public API has Javadoc and @API annotations
• Change is documented in the User Guide and Release Notes

[Pankraz76]

I remember recently seeing this sun.misc.Unsafe to be an issue seen in spot, but not here, despite using the same version.
Assuming this is not needed anymore, right?

Its passing assemble, which is failing when removing some of the disable items.

• Add error-prone.picnic.tech featuring RedundantStringConversion diffplug/spotless#2664

Its just an warning not an error so the cases are different.

WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
WARNING: sun.misc.Unsafe::objectFieldOffset has been called by com.google.common.util.concurrent.AbstractFuture$UnsafeAtomicHelper (file:/Users/vincent.potucek/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.4.0-jre/3fcc0a259f724c7de54a6a55ea7e26d3d5c0cac/guava-33.4.0-jre.jar)
WARNING: Please consider reporting this to the maintainers of class com.google.common.util.concurrent.AbstractFuture$UnsafeAtomicHelper
WARNING: sun.misc.Unsafe::objectFieldOffset will be removed in a future release

vs

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':lib:compileJava'.
> Compilation failed; see the compiler output below.
  /Users/vincent.potucek/IdeaProjects/spotless/lib/src/main/java/com/diffplug/spotless/java/ModuleHelper.java:37: warning: Unsafe is internal proprietary API and may be removed in a future release
  import sun.misc.Unsafe;
                 ^
  1 error
  100 warnings

BUILD FAILED in 22s
14:58:12: Execution finished 'clean assemble'.

maybe then keeping it makes sense again.

[marcphilipp]

The constraint is not an "exclude" but an update of a transitive dependency that's still in action:
https://ge.junit.org/s/miswateogm3po/dependencies?dependencies=guava&expandAll&focusedDependencyView=versions

Without it, noisy warnings are printed during the build:
https://ge.junit.org/s/mvdx45wqr7tom/console-log#L77-L80

[Pankraz76]

Thanks yes updated the doc to prevent any furhter...

[Pankraz76]

Suggested change

	disableAllChecks = !(name == "compileJava" && java.toolchain.implementation.orNull != JvmImplementation.J9)
	disableAllChecks = !(name == "compileJava" && java.toolchain.implementation.orNull != JvmImplementation.J9)

these braces over the whole term cost me lots of time. SOC is always best.

This way we can reduce the field overhead and be straight forward, avoiding the extra context of shouldDisableErrorProne and disableAllChecks is kind of the same story.

[marcphilipp]

This would disable NullAway for compileTestJava etc.

[Pankraz76]

do we need the name == "compileJava" argument, as its also running without?

[marcphilipp]

We want NullAway for all compile tasks but the other Error Prone rules only for compileJava

[Pankraz76]

thanks for clarification. Bad combo leads to failing build anyways, so this should be kind of the same without the coupling right?

• Add error-prone.picnic.tech featuring RedundantStringConversion #5006

[marcphilipp]

The constraint is not an "exclude" but an update of a transitive dependency that's still in action:
https://ge.junit.org/s/miswateogm3po/dependencies?dependencies=guava&expandAll&focusedDependencyView=versions

Without it, noisy warnings are printed during the build:
https://ge.junit.org/s/mvdx45wqr7tom/console-log#L77-L80