Exclude competing @Deprecated factory methods in fallback String-to-Object converter
#5186
+395
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the algorithm to exclude deprecated methods. This extension occurs after the existing logic completes. Fixes junit-team#4996
sbrannen
changed the title
@Deprecated factory methods in fallback String-to-Object converter
Contributor
|
@jodastephen could you satisfy the DCO bot? Oh and please ignore co-pilot. I'm not sure where that came from, but it is not something from the JUnit team. 🤔 |
✅ All tests passed ✅🏷️ Commit: f4b06a2 Learn more about TestLens at testlens.app. |
mpkorstanje
requested changes
Dec 10, 2025
...main/java/org/junit/platform/commons/support/conversion/FallbackStringToObjectConverter.java
Outdated
Show resolved
Hide resolved
mpkorstanje
approved these changes
Dec 16, 2025
Contributor
|
Note: Manually set DTO check to pass. PR was offered before DTO bot was enabled. |
Contributor
Author
|
Thanks, especially for the DCO part! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the fallback String to Object converter algorithm to exclude deprecated methods. This occurs after the existing algorithm finished. As such, any code that works today will continue to work. It is possible that this PR will make some code that fails today start to work, but that seems to be an acceptable outcome.
Release notes will need adding.
Fixes #4996
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations