Repository navigation
Provide access to session-scoped store to Jupiter method/class orderers - #6124
Open
marcphilipp wants to merge 3 commits into
Open
marcphilipp wants to merge 3 commits into
marcphilipp wants to merge 3 commits into
Conversation
marcphilipp
added this pull request to stack #6125
October 6, 2026 13:15
marcphilipp
force-pushed
the
marc/orderer-session-store
branch
from
October 6, 2026 14:49
113965b to
583f8fb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mpkorstanje
reviewed
Oct 9, 2026
marcphilipp
force-pushed
the
marc/orderer-session-store
branch
from
October 23, 2026 11:03
583f8fb to
c421885
Compare
marcphilipp
marked this pull request as ready for review
October 23, 2026 11:10
marcphilipp
force-pushed
the
marc/orderer-session-store
branch
2 times, most recently
from
October 24, 2026 13:54
856559c to
01701e5
Compare
marcphilipp
commented
Oct 24, 2026
| * configuration parameter to {@code false}. | ||
| */ | ||
| interface Store { | ||
| interface Store extends org.junit.jupiter.api.store.Store { |
Member
Author
There was a problem hiding this comment.
I think we should deprecate ExtensionContext.Store and ExtensionContext.Namespace and add methods that take/return the new interfaces instead. Thoughts?
Member
There was a problem hiding this comment.
Makes sense. When would we remove the deprecated methods?
Member
Author
There was a problem hiding this comment.
Theoretically, we could remove them in 7.0. However, that would break extensions that want to be compatible with 5.x. Therefore, realistically, we would keep them for quite while, possibly until 8.0.
marcphilipp
force-pushed
the
marc/orderer-session-store
branch
from
October 24, 2026 17:05
01701e5 to
c36bc54
Compare
Implementations of `ClassOrderer` or `MethodOrderer` may now access the store scoped to the enclosing launcher session via the new `DiscoveryContext.getStoreAccessor(...)` API. This can be used to store or cache information that is reused during test execution or later discovery phases.
marcphilipp
force-pushed
the
marc/orderer-session-store
branch
from
October 25, 2026 18:23
c36bc54 to
e6e90c2
Compare
✅ All tests passed ✅🏷️ Commit: e6e90c2 Learn more about TestLens at testlens.app/docs. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations