Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LabeledArray and documentation #11

Merged
merged 6 commits into from
Nov 28, 2022
Merged

Improve LabeledArray and documentation #11

merged 6 commits into from
Nov 28, 2022

Conversation

junyuan-chen
Copy link
Owner

The changes are mostly on LabeledValue and LabeledArray:

  1. The violation of transitivity of == discussed here has been fixed by removing methods that allow direct comparisons with Strings.
  2. The element type of data array and the key type of the value label dictionary are allowed to be different.
  3. More methods on indexing and array operations are added for LabeledArray.
  4. Phrasing of value labels is more careful to avoid confusion with variable labels. The method labels is renamed to valuelabels as the former will refer to variable labels, in anticipation of the future release of TableMetadataTools.jl.

@junyuan-chen junyuan-chen added documentation Improvements or additions to documentation enhancement New feature or request breaking Breaking changes are involved labels Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #11 (271c02f) into main (26c9daf) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          624       656   +32     
=========================================
+ Hits           624       656   +32     
Impacted Files Coverage Δ
src/ReadStatTables.jl 100.00% <ø> (ø)
src/datetime.jl 100.00% <ø> (ø)
src/LabeledArrays.jl 100.00% <100.00%> (ø)
src/parser.jl 100.00% <100.00%> (ø)
src/table.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@junyuan-chen junyuan-chen merged commit 151e102 into main Nov 28, 2022
@junyuan-chen junyuan-chen deleted the pr/valuelabel branch November 28, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes are involved documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant