Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduced User-Defined outputs_path for Pipeline Execution #402

Merged
merged 6 commits into from
Jun 29, 2023
Merged

feat: Introduced User-Defined outputs_path for Pipeline Execution #402

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
939e53b
used the output_path paremeter in creating the ExecutionContext withi…
MinuraPunchihewa Jun 16, 2023
983fdc8
fix: Local dev
Dr0p42 Jun 19, 2023
7732700
updated the default value of the outputs_path parameter in the run() …
MinuraPunchihewa Jun 19, 2023
1fb8df7
fix: Applied Black
Dr0p42 Jun 22, 2023
ef4abab
fix: apply black
FlorentLvr Jun 27, 2023
f30b4bb
ci(tests): Trying to fix tzlocal
Dr0p42 Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions naas/pipeline/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class ExecutionContext:
output_dir: str = None
output_path: str = None

def __init__(self, output_dir: str = "pipeline_executions"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MinuraPunchihewa, I think that what @jravenel refers to is to keep this default value when output_dir is not provided, that way we will keep the local pipeline_executions directory.

And then we can chose to completely overwrite it 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr0p42 This default value is available in the run() method of the the Pipeline class.

def __init__(self, output_dir: str):
self.execution_id = str(uuid.uuid4())
self.output_dir = output_dir
self.timestamp = datetime.datetime.now()
Expand Down Expand Up @@ -428,7 +428,7 @@ def run(
self,
style: Literal["diagram", "progess"] = "diagram",
monitor: bool = True,
outputs_path="",
outputs_path="pipeline_executions",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dr0p42,
This is what I meant. If the parameter is not passed, the results will be stored in the pipeline_executions directory.

):
"""Start the execution of the pipeline.

Expand Down