Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files_handler_params default from FileContentsManager to ContentsManager #1496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Move files_handler_params from FileContentsManager to ContentsManager…
… to match files_handler_class default
maico committed Jan 29, 2025
commit 51bfc61090dee5291391640f4021b98ffdbf6da7
4 changes: 0 additions & 4 deletions jupyter_server/services/contents/filemanager.py
Original file line number Diff line number Diff line change
@@ -123,10 +123,6 @@ def _checkpoints_class_default(self):
def _files_handler_class_default(self):
return AuthenticatedFileHandler

@default("files_handler_params")
def _files_handler_params_default(self):
return {"path": self.root_dir}

def is_hidden(self, path):
"""Does the API style path correspond to a hidden directory or file?

4 changes: 4 additions & 0 deletions jupyter_server/services/contents/manager.py
Original file line number Diff line number Diff line change
@@ -363,6 +363,10 @@ def _default_checkpoints_kwargs(self):
""",
)

@default("files_handler_params")
def _files_handler_params_default(self):
return {"path": self.root_dir}

def get_extra_handlers(self):
"""Return additional handlers