Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized kernel specs #1028

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

AnastasiaSliusar
Copy link

@AnastasiaSliusar AnastasiaSliusar commented Jun 13, 2024

References

This work is in progress as JEP jupyter/enhancement-proposals#87.
This PR should be reviewed when the JEP has been accepted

Code changes

  • Replacing kernel spec variables for arg and env that are in kernel.json on values from custom_kernel_specs parameter which is configured by a user. custom_kernel_specs is passed from Jupyter Lab through jupyter_server.
  • Clearing kernel spec variables that are in kernel.json if they are present into this file but custom_kernel_specs parameter is missed
  • Adding basic validation to check whether custom_kernel_specs does not include anything wrong
  • Adding support if a kernel.json file includes customization for a kernel but a user has not selected anything then a parameterized kernel will be run by using default values from its kernel.json file

How to run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants