-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterized kernel specs #1028
Draft
AnastasiaSliusar
wants to merge
40
commits into
jupyter:main
Choose a base branch
from
AnastasiaSliusar:parametrizing_kernels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Parameterized kernel specs #1028
AnastasiaSliusar
wants to merge
40
commits into
jupyter:main
from
AnastasiaSliusar:parametrizing_kernels
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This was referenced Jun 13, 2024
for more information, see https://pre-commit.ci
…liusar/jupyter_client into parametrizing_kernels
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This work is in progress as JEP jupyter/enhancement-proposals#87.
This PR should be reviewed when the JEP has been accepted
Code changes
kernel.json
on values fromcustom_kernel_specs
parameter which is configured by a user.custom_kernel_specs
is passed from Jupyter Lab through jupyter_server.kernel.json
if they are present into this file butcustom_kernel_specs
parameter is missedHow to run
Parameterized kernel specs jupyterlab/jupyterlab#16487
Parameterized kernel specs jupyter-server/jupyter_server#1431