[DO NOT MERGE] Specify that the debug messages follow the debug adapter protocol #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetaKernelFinder -> KernelFinder
Prototype new kernel discovery machinery
Fix typo in documentation.
The old URL points to a "This page has moved"-page
Updated URL for Jupyter Kernels in other languages
- use IOLoop.current over IOLoop.instance - drop removed `loop` arg from PeriodicCallback - deprecate now-unused IOLoopKernelRestarter.loop
- interrupt_mode="signal" is the default and current behaviour - With interrupt_mode="message", instead of a signal, a `interrupt_request` message on the control port will be sent
prepare for tornado 5
Additional to the actual signal, send a message on the control port
this should allow ipykernel's wheel-installed specs to specify `python3` or `python2` and prevent python2 kernels from launching with sys.executable if the Python version is 3.
A simple lead in to the 'kernel nanny' work, this adds a command so you can do: jupyter kernel --kernel python
Updates to the kernel messaging spec
cocalc now properly works; also add a concrete example of an "astral plane unicode" identifier, so anybody can easily see what happens in the Jupyter client of their choice.
Document debug_[request|reply] and debug_event
This change tolerates the existence of templated entries where the templated value corresponds to an existing environment variable. In such cases, those templated values will be substituted prior to the kernel's launch.
Add support for templated env entries
Prevent two kernels to have the same ports assigned in MultiKernelManager
Prevent two kernels to have the same ports
Only cache ports if the cache_ports flag is set to True
use session_id and message counter. This gives a unique id but uses much less time
Session.msg_id optimization
SylvainCorlay
force-pushed
the
debug-adapter-protocol
branch
from
76f6187
to
1f36942
Compare
|
We should probably add a description of the I think this could be done in a separate PR. |
|
|
jtpio
reviewed
Dec 30, 2019
jtpio
reviewed
Dec 30, 2019
SylvainCorlay
force-pushed
the
debug-adapter-protocol
branch
from
1f36942
to
492efc6
Compare
10 tasks
|
Please do not merge. I am opening a JEP. |
SylvainCorlay
changed the title
jasongrout
changed the title
jasongrout
requested changes
Dec 30, 2019
SylvainCorlay
force-pushed
the
master
branch
from
b1fe8e4
to
3e8ee4a
Compare
|
Note: this needs a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.