Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission scores in Assigment List #1934

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KrKOo
Copy link

@KrKOo KrKOo commented Nov 5, 2024

With this PR, the scores for each assignment are displayed directly on the assignment list page, significantly enhancing the course overview from the student's perspective.

  • Updated feedback template
    The only source of scores accessible to students is the feedback.html file. To facilitate easier parsing, the default template has been modified by adding tags to store the student's earned score. This change also allows custom templates to be parsed conveniently, provided they incorporate these meta tags.

  • Updated Exchange
    The default exchange now parses the feedback file and retrieves the score and max_score attributes for each submission. If multiple feedbacks are available, the score from the last one is returned.

  • Backward Compatibility

    • Since this update relies on the new tags in feedback files, scores will not be displayed for older assignments.
    • If a custom exchange does not return scores, they will not appear in the UI.

image

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Binder 👈 Launch a Binder on branch KrKOo/nbgrader/assignment-list-score

@perllaghu
Copy link
Contributor

Can I confirm that the scores in the assignment list are taken from the feedback file(s) in the students directory-tree?

[I think that's how I read it....]

@KrKOo
Copy link
Author

KrKOo commented Nov 5, 2024

Yes

@lahwaacz
Copy link
Contributor

Why do you need to contact the exchange to get the score for display? When the feedback is already downloaded by the user, the assignment_list JupyterLab extension can just contact its Jupyter server counterpart that would extract the values from the downloaded file. This would avoid the need to upgrade any external exchange code to support the new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants