Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the filebrowser search bar to the toolbar #6342

Closed
wants to merge 3 commits into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 4, 2022

Fixes #6341

Opening early as a proof of concept.

This help save some vertical space, which is particularly useful on mobile devices.

TODO

  • Register the file searcher via the toolbar registry
  • Fix upstream to allow to not show the file search bar
  • Fix upstream to access listing?

Before

image

After

image

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Binder 👈 Launch a Binder on branch jtpio/notebook/filebrowser-search

@jtpio jtpio added this to the 7.0 milestone Apr 4, 2022
@jtpio
Copy link
Member Author

jtpio commented Apr 19, 2022

This will likely need jupyterlab/jupyterlab#12347 to be fixed and released in JupyterLab first, before being able to continue here.

@jtpio
Copy link
Member Author

jtpio commented Oct 15, 2022

An alternative would be to keep this space for the action buttons for the file browser: #6378

@jtpio jtpio self-assigned this Jan 11, 2023
@jtpio
Copy link
Member Author

jtpio commented Feb 22, 2023

Opened jupyterlab/jupyterlab#14064 to fix it upstream.

@jtpio jtpio mentioned this pull request Mar 3, 2023
9 tasks
@jtpio jtpio closed this in #6757 Mar 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the file browser search bar to the toolbar?
1 participant