Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyter-server #11

Closed
wants to merge 1 commit into from
Closed

Conversation

hbcarlos
Copy link

Updates jupyter-server dependency to use jupyter-server>=2,<3

@hbcarlos
Copy link
Author

@Zsailer, Why are we pinning jupyer-server=1.8?

@jtpio
Copy link
Member

jtpio commented Aug 10, 2022

@Zsailer, Why are we pinning jupyer-server=1.8?

Looks like it's jupyter_server~=1.8 using the ~= specifier, not an exact pin, which means it accepts jupyter_server>=1.8,<2?

@hbcarlos
Copy link
Author

ooh, that's right. Thanks, @jtpio!

@hbcarlos hbcarlos marked this pull request as draft August 11, 2022 14:22
@Zsailer
Copy link
Member

Zsailer commented Sep 8, 2022

Thanks, @hbcarlos. See #12

I don't think we want to require > 2.0. We just need to raise the ceiling on allowed versions of Jupyter Server. JupyterLab 4.0 can require >2, but I don't think we should enforce this on all consumers of notebook_shim.

@hbcarlos
Copy link
Author

Thanks, @Zsailer! Makes sense.
Anyway, I'm closing this since you already change it in #12

@hbcarlos hbcarlos closed this Sep 12, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants