Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: extend GHA test matrix to current Python versions #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

TST: extend GHA test matrix to current Python versions #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9b36e1
TST: more py312 compatibility changes in tests
tacaswell May 13, 2024
fdb49d6
TST: extend GHA test matrix to current Python versions
tacaswell May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/unittest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.6", "3.7", "3.8", "3.9"]
exclude:
- os: macos-latest
python-version: "3.6"
os: [ubuntu-latest, windows-latest]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
include:
- os: macos-12 # This runner is on Intel chips.
python-version: 3.9
- os: macos-14 # This runner is on M1 (arm64) chips.
python-version: '3.12'
steps:
- name: Checkout
uses: actions/checkout@v1
Expand Down
4 changes: 4 additions & 0 deletions jupyter_telemetry/tests/test_allowed_schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,5 +206,9 @@ def test_allowed_schemas(schema, allowed_schemas, expected_output):
allowed_schemas
)

# Cope with python3.12
if "taskName" in event_data:
del event_data["taskName"]

# Verify that *exactly* the right properties are recorded.
assert expected_output == event_data
20 changes: 20 additions & 0 deletions jupyter_telemetry/tests/test_category_filtering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ def test_category_filtering(allowed_schemas, expected_output):
allowed_schemas
)

# Cope with python3.12
if "taskName" in event_data:
del event_data["taskName"]

# Verify that *exactly* the right properties are recorded.
assert expected_output == event_data

Expand Down Expand Up @@ -291,6 +295,10 @@ def test_array_category_filtering(allowed_schemas, expected_output):
allowed_schemas
)

# Cope with python3.12
if "taskName" in event_data:
del event_data["taskName"]

# Verify that *exactly* the right properties are recorded.
assert expected_output == event_data

Expand Down Expand Up @@ -395,6 +403,10 @@ def test_no_additional_properties(allowed_schemas, expected_output):
allowed_schemas
)

# Cope with python3.12
if "taskName" in event_data:
del event_data["taskName"]

# Verify that *exactly* the right properties are recorded.
assert expected_output == event_data

Expand Down Expand Up @@ -488,6 +500,10 @@ def test_category_filtering_ref(allowed_schemas, expected_output):
allowed_schemas
)

# Cope with python3.12
if "taskName" in event_data:
del event_data["taskName"]

# Verify that *exactly* the right properties are recorded.
assert expected_output == event_data

Expand All @@ -504,5 +520,9 @@ def test_category_filtering_allof(allowed_schemas, expected_output):
allowed_schemas
)

# Cope with python3.12
if "taskName" in event_data:
del event_data["taskName"]

# Verify that *exactly* the right properties are recorded.
assert expected_output == event_data
Loading