Skip to content

add mount type for volume_binds generated mounts #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Open

add mount type for volume_binds generated mounts #537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff34ea1
add mount type for volume_binds generated mounts
kreuzert May 13, 2025
6bd1b8d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion dockerspawner/swarmspawner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,16 @@ def mount_driver_config(self):
)
return None

volume_binds_mount_type = Unicode(
default_value="bind",
allow_None=False,
config=True,
help="""
Use this mount type for creating mounts of volume_binds.
Check https://docs.docker.com/engine/storage/volumes/ for allowed mount types.
""",
)

@property
def mounts(self):
if len(self.volume_binds):
Expand All @@ -124,7 +134,7 @@ def mounts(self):
Mount(
target=vol["bind"],
source=host_loc,
type="bind",
type=self.volume_binds_mount_type,
read_only=vol["mode"] == "ro",
driver_config=driver,
)
Expand Down
Loading