Get JUPYTERHUB_API_TOKEN from secret #693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
dolfinus
reviewed
Jan 17, 2023
Co-authored-by: Maxim Martynov <[email protected]>
dolfinus
reviewed
Jan 18, 2023
| name="JUPYTERHUB_API_TOKEN", | ||
| value_from=V1EnvVarSource( | ||
| secret_key_ref=V1SecretKeySelector( | ||
| name=user_secret_name, key="JUPYTERHUB_API_TOKEN" |
There was a problem hiding this comment.
Why secret ref name is configurable, but secret name itself is not?
There was a problem hiding this comment.
The ref has to be unique per user, so we need to pass it the user name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to reslove #398
This might be redundant from #471