Add remote update support#342
Open
ctriquet-cs wants to merge 1 commit intojupyterhub:mainfrom
Open
Conversation
ctriquet-cs
force-pushed
the
manage_remote
branch
from
c00e434 to
5d4cedd
Compare
Author
|
Just re-based that PR on current main. |
Member
|
Hey @ctriquet-cs ! I know it's been a long time but thanks for making this PR. In general, I would not paste tokens into URLs since they are logged on the server and so anyone with access to the server logs can see your private token. I've opened a PR to document this warning in #387 and suggested an alternative approach using https://github.com/yuvipanda/git-credential-helpers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloning a Git repository for an authenticated server can be achieved with a repository URL of the form "https://login:token@hostname/path.git". When using an token with a limited validated period, the initial cloning with nbgitpuller is successful, but subsequent synchronizations fails. Indeed, the initial token was stored into local repository settings and is no more valid and the new one transmitted by a new call to nbgitpuller is ignored.
That PR proposes to update the repository remote URL before an repository update.
That change is done if required and only URL credentials are updated, hostname and repository path can't be updated.