Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in overridable options to child spawners #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Petraea
Copy link

@Petraea Petraea commented Aug 2, 2017

Hi there,
In addition to the profile defaults, it is occasionally handy to be able to set up user-editable fields in the ProfilesSpawner option form. To do this, the config has to be passed in from the form itself (and optionally overidden by values in the profile).

@mbmilligan
Copy link
Member

Hi, thanks for the contribution!

I'm sorry to say, I'm having trouble understanding exactly how this change works. Can you tell me a little more about your use case and how you are implementing it? For one thing, I presume you are overriding the form creation at some point, since presently it doesn't generate editable form fields. I'm trying to reason about the effect of making options_from_form() have side-effects when it didn't before, and that would be easier with a concrete example of the sort of form data you are generating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants