Skip to content

Commit

Permalink
Pin jupyterlab in test
Browse files Browse the repository at this point in the history
  • Loading branch information
trungleduc committed Dec 11, 2024
1 parent a79a6cf commit 89df75a
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
11 changes: 10 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Setup locale
run: |
sudo apt-get update
sudo apt-get install -y locales
sudo locale-gen en_US.UTF-8
export LANG=en_US.UTF-8
export LANGUAGE=en_US:en
export LC_ALL=en_US.UTF-8
- name: Checkout
uses: actions/checkout@v4

Expand Down Expand Up @@ -44,7 +53,7 @@ jobs:
set -eux
pip install hatch
yarn build:packages
jlpm build:packages
- name: Upload extension packages
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"npmClient": "yarn",
"npmClient": "jlpm",
"version": "independent",
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"packages": [
Expand Down
4 changes: 2 additions & 2 deletions python/jupyter_suggestions/scripts/bump-version.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def bump():
root_json = json.loads(package_json.read_text(encoding="utf-8"))
root_json["version"] = js_version
package_json.write_text(json.dumps(root_json), encoding="utf-8")
run(["yarn", "install"], check=True)
run(["jlpm", "install"], check=True)
run(
[
"node",
Expand All @@ -64,7 +64,7 @@ def bump():
# pin jupyter_suggestions_* package to the same version
bump_jupyter_suggestions_deps(py_version)
# bump the JS version with lerna
run(f"yarn run bump:js:version {js_version}", shell=True, check=True)
run(f"jlpm run bump:js:version {js_version}", shell=True, check=True)


if __name__ == "__main__":
Expand Down

0 comments on commit 89df75a

Please sign in to comment.