Skip to content

Commit

Permalink
Update packages/base/src/types.ts
Browse files Browse the repository at this point in the history
Co-authored-by: Jeremy Tuloup <[email protected]>
  • Loading branch information
trungleduc and jtpio committed Dec 19, 2024
1 parent 1d2e455 commit f409c47
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/base/src/suggestionsPanel/model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export class SuggestionsModel implements ISuggestionsModel {
}
}

nativateToCell(cellId?: string): void {
scrollToCell(cellId?: string): void {
if (cellId && this._notebookPanel) {
const index = this.getCellIndex(cellId);
if (index !== -1) {
Expand Down
2 changes: 1 addition & 1 deletion packages/base/src/suggestionsPanel/widget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ export class SuggestionsWidget extends PanelWithToolbar {
}
};
const navigateCallback = async () => {
this._model.nativateToCell(cellId);
this._model.scrollToCell(cellId);
};
let Cls: typeof BaseCellwidget = BaseCellwidget;
switch (suggestionData.type) {
Expand Down
2 changes: 1 addition & 1 deletion packages/base/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export interface ISuggestionsModel extends IDisposable {
* Scroll to the cell by its id
*
*/
nativateToCell(cellId?: string): void;
scrollToCell(cellId?: string): void;
}

export interface ISuggestionChange {
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10332,7 +10332,7 @@ __metadata:

"typescript@patch:typescript@>=3 < 6#~builtin<compat/typescript>, typescript@patch:typescript@^5#~builtin<compat/typescript>":
version: 5.7.2
resolution: "typescript@patch:typescript@npm%3A5.7.2#~builtin<compat/typescript>::version=5.7.2&hash=85af82"
resolution: "typescript@patch:typescript@npm%3A5.7.2#~builtin<compat/typescript>::version=5.7.2&hash=e012d7"
bin:
tsc: bin/tsc
tsserver: bin/tsserver
Expand All @@ -10342,11 +10342,11 @@ __metadata:

"typescript@patch:typescript@~5.0.2#~builtin<compat/typescript>":
version: 5.0.4
resolution: "typescript@patch:typescript@npm%3A5.0.4#~builtin<compat/typescript>::version=5.0.4&hash=85af82"
resolution: "typescript@patch:typescript@npm%3A5.0.4#~builtin<compat/typescript>::version=5.0.4&hash=b5f058"
bin:
tsc: bin/tsc
tsserver: bin/tsserver
checksum: bb309d320c59a26565fb3793dba550576ab861018ff3fd1b7fccabbe46ae4a35546bc45f342c0a0b6f265c801ccdf64ffd68f548f117ceb7f0eac4b805cd52a9
checksum: d26b6ba97b6d163c55dbdffd9bbb4c211667ebebc743accfeb2c8c0154aace7afd097b51165a72a5bad2cf65a4612259344ff60f8e642362aa1695c760d303ac
languageName: node
linkType: hard

Expand Down

0 comments on commit f409c47

Please sign in to comment.