Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow registering multiple suggestion handlers #11

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Allow registering multiple suggestion handlers #11

merged 5 commits into from
Dec 4, 2024

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Dec 3, 2024 •
edited
Loading

Code changes

  • New token ISuggestionsManagerRegistryToken allowing other extensions to register suggestion manager
  • New setting entry for Jupyter Suggestion to select suggestion manager among the registered ones.

This PR allows us to register a suggestion manager backed by jupyter-collaboration

suggestion-setting

@trungleduc trungleduc added the enhancement New feature or request label Dec 3, 2024
@trungleduc trungleduc marked this pull request as ready for review December 3, 2024 22:20
@trungleduc trungleduc requested a review from jtpio December 3, 2024 22:20
trungleduc and others added 2 commits December 4, 2024 08:55
@trungleduc @jtpio
Update plugins.ts
16336ad 
Co-authored-by: Jeremy Tuloup <[email protected]>
@trungleduc @jtpio
Update registry.json
f751487 
Co-authored-by: Jeremy Tuloup <[email protected]>
jtpio
jtpio approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit df7595a into jupyterlab-contrib:main Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @jtpio