Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to monorepo #3

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Convert to monorepo #3

merged 6 commits into from
Nov 20, 2024

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Nov 20, 2024 •
edited
Loading

Code changes

  • Rename python package to jupyter_suggestions and JS package to @jupyter-suggestions/*
  • Switch to a monorepo structure
  • Add script to install the project in dev mode and to bump version.

@trungleduc
Copy link
Member Author

trungleduc commented Nov 20, 2024 •
edited
Loading

@jtpio I'm renaming the package to jupyter-suggestions to shorten the package name and avoid confusion when using this package with Jupyter Notebook.

@jtpio
Copy link
Member

jtpio commented Nov 20, 2024

@jtpio I'm renaming the package to jupyter-suggestions to shorten the package name and avoid confusion when using this package with Jupyter Notebook.

Sounds good 👍 We can also rename the repo afterwards for consistency.

@trungleduc trungleduc force-pushed the ui branch 4 times, most recently from fef633a to c5bcf66 Compare November 20, 2024 10:12
@trungleduc trungleduc marked this pull request as ready for review November 20, 2024 13:05
@trungleduc trungleduc requested a review from jtpio November 20, 2024 13:08
jtpio
jtpio reviewed Nov 20, 2024
View reviewed changes
package.json Show resolved Hide resolved
jtpio
jtpio approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Nov 20, 2024

Also quick question: do you envision the metapackage to be used for something in particular?

@trungleduc
Copy link
Member Author

Also quick question: do you envision the metapackage to be used for something in particular?

not yet, I'm just copying the structure from JupyterCAD

@trungleduc trungleduc merged commit eaff78e into jupyterlab-contrib:main Nov 20, 2024
7 checks passed
@trungleduc trungleduc deleted the ui branch November 22, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @jtpio