Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffolding UI #4

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Scaffolding UI #4

merged 4 commits into from
Nov 21, 2024

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Nov 21, 2024

User-facing changes

  • Add suggestion panel
  • Add suggestion button to the cell toolbar

ui

@trungleduc trungleduc added the enhancement New feature or request label Nov 21, 2024
@trungleduc trungleduc marked this pull request as ready for review November 21, 2024 18:28
@trungleduc trungleduc requested a review from jtpio November 21, 2024 18:28
@@ -0,0 +1,14 @@
{
"title": "@jupyter-suggestions/jupyter-suggestions-core",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the @jupyter-suggestions scope a placeholder, or should we go with something like this for the final package name?

If so I guess it would be fine to already create the org on npm. Otherwise we could also use the @jupyter or @jupyterlab scopes later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I'm going to switch to @jupyter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to ask for permission to publish packages under this org?

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

Happy to merge so it's easier to iterate. Thanks for working on this!

@trungleduc trungleduc merged commit f2b4880 into jupyterlab-contrib:main Nov 21, 2024
7 checks passed
@trungleduc trungleduc deleted the add-panel branch November 22, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants