-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Improve icon element DOM tree * Add icon style * Fix styles for slots with icon * Export the icon * Add the react icon component * Allow to register icons using the react component * Fix tests * Fix format * Sanitize icon SVG strings * Update button icon snapshots --------- Co-authored-by: Frédéric Collonval <[email protected]>
- Loading branch information
1 parent
1583278
commit b418fb3
Showing
68 changed files
with
255 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-25 Bytes
(99%)
...adcrumb-item.test.ts-snapshots/breadcrumb-item-with-end-icon-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-56 Bytes
(98%)
...eadcrumb-item.test.ts-snapshots/breadcrumb-item-with-end-icon-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-68 Bytes
(98%)
...readcrumb-item.test.ts-snapshots/breadcrumb-item-with-end-icon-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-24 Bytes
(99%)
...crumb-item.test.ts-snapshots/breadcrumb-item-with-start-icon-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-44 Bytes
(98%)
...dcrumb-item.test.ts-snapshots/breadcrumb-item-with-start-icon-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-28 Bytes
(99%)
...adcrumb-item.test.ts-snapshots/breadcrumb-item-with-start-icon-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-933 Bytes
(85%)
...dcrumb/breadcrumb.test.ts-snapshots/breadcrumb-with-end-icon-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+48 Bytes
(100%)
...adcrumb/breadcrumb.test.ts-snapshots/breadcrumb-with-end-icon-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-121 Bytes
(98%)
...eadcrumb/breadcrumb.test.ts-snapshots/breadcrumb-with-end-icon-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+11 Bytes
(100%)
...rumb/breadcrumb.test.ts-snapshots/breadcrumb-with-start-icon-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-37 Bytes
(99%)
...crumb/breadcrumb.test.ts-snapshots/breadcrumb-with-start-icon-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+53 Bytes
(100%)
...dcrumb/breadcrumb.test.ts-snapshots/breadcrumb-with-start-icon-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-21 Bytes
(96%)
...ponents/src/button/button.test.ts-snapshots/button-icon-only-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-29 Bytes
(94%)
...mponents/src/button/button.test.ts-snapshots/button-icon-only-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-145 Bytes
(83%)
...omponents/src/button/button.test.ts-snapshots/button-icon-only-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-17 Bytes
(99%)
...s/src/button/button.test.ts-snapshots/button-with-start-icon-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-56 Bytes
(97%)
...ts/src/button/button.test.ts-snapshots/button-with-start-icon-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-137 Bytes
(96%)
...nts/src/button/button.test.ts-snapshots/button-with-start-icon-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+0 Bytes
(100%)
...ombobox/combobox.test.ts-snapshots/combobox-custom-indicator-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
...combobox/combobox.test.ts-snapshots/combobox-custom-indicator-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-38 Bytes
(99%)
...ield/date-field.test.ts-snapshots/date-field-with-start-icon-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+18 Bytes
(100%)
...field/date-field.test.ts-snapshots/date-field-with-start-icon-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+25 Bytes
(100%)
...-field/date-field.test.ts-snapshots/date-field-with-start-icon-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Copyright (c) Jupyter Development Team. | ||
// Distributed under the terms of the Modified BSD License. | ||
|
||
import { css, ElementStyles } from '@microsoft/fast-element'; | ||
import { display } from '@microsoft/fast-foundation'; | ||
import { heightNumber } from '../styles/index.js'; | ||
|
||
/** | ||
* Styles for Badge | ||
* @public | ||
*/ | ||
export const iconStyles: ElementStyles = css` | ||
${display('inline-block')} :host { | ||
inline-size: ${heightNumber}; | ||
block-size: ${heightNumber}; | ||
} | ||
:host svg { | ||
display: block; | ||
width: 100%; | ||
height: 100%; | ||
} | ||
`; |
Binary file modified
BIN
-283 Bytes
(67%)
.../components/src/icon/icon.test.ts-snapshots/icon-change-icon-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.24 KB
(25%)
...s/components/src/icon/icon.test.ts-snapshots/icon-change-icon-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-697 Bytes
(59%)
...es/components/src/icon/icon.test.ts-snapshots/icon-change-icon-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
-285 Bytes
(68%)
...ages/components/src/icon/icon.test.ts-snapshots/icon-default-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.19 KB
(24%)
packages/components/src/icon/icon.test.ts-snapshots/icon-default-firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-686 Bytes
(62%)
packages/components/src/icon/icon.test.ts-snapshots/icon-default-webkit-linux.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+218 Bytes
(100%)
...ages/components/src/menu/menu.test.ts-snapshots/menu-default-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+78 Bytes
(100%)
packages/components/src/menu/menu.test.ts-snapshots/menu-default-firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+360 Bytes
(100%)
packages/components/src/menu/menu.test.ts-snapshots/menu-default-webkit-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2 Bytes
(100%)
.../number-field.test.ts-snapshots/number-field-with-start-icon-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1 Byte
(100%)
...d/number-field.test.ts-snapshots/number-field-with-start-icon-firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-4 Bytes
(100%)
...ld/number-field.test.ts-snapshots/number-field-with-start-icon-webkit-linux.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+21 Bytes
(100%)
...select/select.test.ts-snapshots/select-with-custom-indicator-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1 Byte
(100%)
.../select/select.test.ts-snapshots/select-with-custom-indicator-firefox-linux.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.