Require jupyterlab>=4.1.2 for arrow key compatibility #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #66
As noted in the original issue, left and right arrows keys could not be used to navigate through slides as they collided with JupyterLab's keybindings for collapsing and uncollapsing headers.
JupyterLab changed the shortcut selectors to a more specific ".jp-Notebook.jp-mod-commandMode:not(.jp-mod-readWrite) :focus" in version 4.1.2 which appears to no longer target the RISE slideshow. Originally this was just just ".jp-Notebook:focus.jp-mod-commandMode".
To avoid people running into this issue with earlier versions of JupyterLab I added a requirement to have jupyterlab >= 4.1.2. Feel free to suggest any alternatives. Thanks.