Adds side panel widgets to the tracker #146
Open
+149
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
reviewed
Feb 5, 2025
| @@ -56,7 +57,7 @@ export interface IChatFactory { | |||
| /** | |||
| * The chat panel tracker. | |||
| */ | |||
| tracker: IWidgetTracker<LabChatPanel>; | |||
| tracker: WidgetTracker<LabChatPanel | ChatWidget>; | |||
There was a problem hiding this comment.
Do we need to expose a full WidgetTracker? Or could we stick to the more limited IWidgetTracker as before?
jtpio
reviewed
Feb 5, 2025
| @@ -152,16 +152,13 @@ export class ChatPanel extends SidePanel { | |||
| * @param model - the model of the chat widget | |||
| * @param name - the name of the chat. | |||
| */ | |||
| addChat(model: IChatModel, path: string): void { | |||
| addChat(model: IChatModel): ChatWidget { | |||
There was a problem hiding this comment.
Note: this will likely require a 0.8.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the side panel chats to the widget tracker.
Fixes #130
Fixes #139
The chats tracker tracks both
LabChatPanel(the main area widget) andChatWidget(widget in the side panel).IMPROVEMENT
Accel Shift 1) works for all the chat widgets. The last used input is focused.TO DO
The widget become the current widget of the tracker only if an input has been clicked. We should focus on the input component when the chat is clicked (anywhere except on an other input). This would also be a nice UX improvement.