Fix requiring position for undetermined index (#549)

jupyterlab · Mar 6, 2023 · 6c1fe7c · 6c1fe7c
1 parent e3c2213
commit 6c1fe7c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/widgets/src/menubar.ts b/packages/widgets/src/menubar.ts
@@ -699,7 +699,8 @@ export class MenuBar extends Widget {
     }
 
     // Get position for the new menu >before< updating active index.
-    const position = this._positionForMenu(index);
+    const position =
+      index >= 0 && this._childMenu ? this._positionForMenu(index) : null;
 
     // Before any modification, update window data.
     Menu.saveWindowData();
@@ -710,7 +711,7 @@ export class MenuBar extends Widget {
     this.activeIndex = index;
 
     // Open the new menu if a menu is already open.
-    if (this._childMenu) {
+    if (position) {
       this._openChildMenu(position);
     }
   }