Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requiring position for MenuBar undetermined index #549

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Fix requiring position for MenuBar undetermined index #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/widgets/src/menubar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,8 @@ export class MenuBar extends Widget {
}

// Get position for the new menu >before< updating active index.
const position = this._positionForMenu(index);
const position =
index >= 0 && this._childMenu ? this._positionForMenu(index) : null;
krassowski marked this conversation as resolved.
Show resolved Hide resolved

// Before any modification, update window data.
Menu.saveWindowData();
Expand All @@ -710,7 +711,7 @@ export class MenuBar extends Widget {
this.activeIndex = index;

// Open the new menu if a menu is already open.
if (this._childMenu) {
if (position) {
this._openChildMenu(position);
}
}
Expand Down