feat: added delete override modal #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauraww
force-pushed
the
feat/delete-override-modal
branch
from
6ad101b to
842dc3e
Compare
mahatoankitkumar
requested changes
Jun 20, 2024
| @@ -326,6 +342,22 @@ pub fn context_override() -> impl IntoView { | |||
| }} | |||
|
|
|||
| </div> | |||
|
|
|||
| <Show when=move || modal_visible.get()> | |||
There was a problem hiding this comment.
@sauraww Can you make this a separate module for future usage?
There was a problem hiding this comment.
And make the tailwind a bit cleaner to read by separating out common ones, hard to read those.
There was a problem hiding this comment.
Agreed on making this a component that can be quickly used since we have deletes in multiple screens
| <dialog id="my_modal_2" class="modal" open={modal_visible.get()}> | ||
| <div class="modal-box bg-white rounded-lg p-6 shadow-xl border-2 border-lightgray"> | ||
| <h4 class="text-xl font-semibold text-gray-800 mb-4">Confirm Deletion</h4> | ||
| <p class="text-sm text-gray-600 mb-6">Are you sure you want to delete this context? This action cannot be undone.</p> |
There was a problem hiding this comment.
Suggested change
| <p class="text-sm text-gray-600 mb-6">Are you sure you want to delete this context? This action cannot be undone.</p> | |
| <p class="text-sm text-gray-600 mb-6"> Are you sure you want to delete this context? Action is irreversible.</p> |
Datron
reviewed
Jun 20, 2024
| <h4 class="text-xl font-semibold text-gray-800 mb-4">Confirm Deletion</h4> | ||
| <p class="text-sm text-gray-600 mb-6">Are you sure you want to delete this context? This action cannot be undone.</p> | ||
| <div class="flex justify-end space-x-4"> | ||
| <button class="btn bg-purple-500 text-white px-4 py-2 rounded hover:opacity-75 hover:bg-purple-500" on:click=confirm_delete>Yes, Delete</button> |
There was a problem hiding this comment.
This should be rounded buttons and follow the same look we have for all buttons
sauraww
force-pushed
the
feat/delete-override-modal
branch
2 times, most recently
from
c423efc to
49fad50
Compare
pratikmishra356
approved these changes
Jul 3, 2024
Datron
approved these changes
Jul 3, 2024
| <p class="text-sm text-gray-600 mb-6">{header_text.clone()}</p> | ||
| <div class="flex justify-end space-x-4"> | ||
| <button class="btn bg-purple-500 font-medium rounded-lg text-sm text-center text-white px-5 py-2.5 me-2 mb-2 hover:opacity-75 hover:bg-purple-500" on:click=move |_| confirm_delete.call(()) >Yes, Delete</button> | ||
| <button class="btn bg-gray-300 font-medium rounded-lg text-sm text-center text-black px-5 py-2.5 me-2 mb-2 hover:opacity-75 hover:bg-gray-300" on:click=move |_| set_modal_visible.set(false)>No </button> |
There was a problem hiding this comment.
except bg-color make a variable and use that will be cleaner.
sauraww
force-pushed
the
feat/delete-override-modal
branch
from
49fad50 to
3ba41b1
Compare
sauraww
force-pushed
the
feat/delete-override-modal
branch
from
3ba41b1 to
eb3974c
Compare
mahatoankitkumar
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Delete button in the override feature was deleting overrides immediately, without requesting user confirmation. This behavior poses a risk as these overrides are sensitive and critical.
Solution
Implemented a confirmation modal that appears when the Delete button is clicked. This modal prompts the user to confirm whether they really want to delete the override. The override will only be deleted if the user confirms by selecting "Yes."
Here is the screeshot for the UI Review :