fix: allow positive i32 number for dimension priority in dimension create #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushjain17
force-pushed
the
temp/dimensionPriority
branch
from
b7d6292 to
6fbe1f5
Compare
Datron
approved these changes
Jun 27, 2024
| @@ -195,8 +195,8 @@ where | |||
| class="input input-bordered w-full max-w-md" | |||
| value=priority.get() | |||
| on:change=move |ev| { | |||
| logging::log!("{:?}", event_target_value(& ev).parse::< u16 > ()); | |||
| match event_target_value(&ev).parse::<u16>() { | |||
| logging::log!("{:?}", event_target_value(& ev).parse::< u32 > ()); | |||
There was a problem hiding this comment.
Suggested change
| logging::log!("{:?}", event_target_value(& ev).parse::< u32 > ()); | |
| logging::log!("{:?}", event_target_value(& ev).parse::<u32>()); |
ayushjain17
force-pushed
the
temp/dimensionPriority
branch
from
6fbe1f5 to
d05e6ee
Compare
Datron
reviewed
Jun 27, 2024
Comment on lines
37
to
43
| return Err(bad_argument!("Priority should be greater than 0")); | ||
| } | ||
|
|
||
| if req.priority < 0 { | ||
| return Err(bad_argument!("Expected positive value for priority",)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we merge both of these checks?
ayushjain17
force-pushed
the
temp/dimensionPriority
branch
from
d05e6ee to
038952e
Compare
ShubhranshuSanjeev
requested changes
Jun 27, 2024
ayushjain17
force-pushed
the
temp/dimensionPriority
branch
2 times, most recently
from
ea23ed3 to
b44a4fc
Compare
pratikmishra356
approved these changes
Jun 27, 2024
ayushjain17
force-pushed
the
temp/dimensionPriority
branch
from
b44a4fc to
912bf10
Compare
ShubhranshuSanjeev
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DB supports i32 values for priority but endpoints were restricted to u16
Solution
allow positive i32 number for dimension priority in dimension create