Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: x-config-version in get config and experiments response #152

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: x-config-version in get config and experiments response #152

merged 1 commit into from
Jul 9, 2024

Conversation

ayushjain17
Copy link
Collaborator

Problem

  1. x-config-version not being sent in get config or resolve config if the request does not include any config-version
  2. experiments wrongly tagging version as tags

Solution

fetch latest config version and return response from there if no config version is provided, if there are no snapshots, then fallback to default flow

@ayushjain17 ayushjain17 requested a review from a team as a code owner July 9, 2024 11:53
@sauraww sauraww merged commit 1a429a9 into main Jul 9, 2024
4 checks passed
@sauraww sauraww deleted the configVersionFix branch July 9, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikmishra356 pratikmishra356 pratikmishra356 approved these changes

@sauraww sauraww sauraww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushjain17 @pratikmishra356 @sauraww