fix: undo stringify of last_modified timestamp #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauraww
approved these changes
Jul 10, 2024
sauraww
requested changes
Jul 10, 2024
| if let Ok(header_value) = value { | ||
| resp_builder | ||
| .insert_header((AppHeader::LastModified.to_string(), header_value)); | ||
| } |
There was a problem hiding this comment.
Possible to log the error if the parse fails ?
sauraww
approved these changes
Jul 10, 2024
pratikmishra356
force-pushed
the
fix-last-modified-format
branch
from
3ba8d19 to
6cad389
Compare
Datron
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Stringified last_modified header
Solution
parse it as rfc2822
Environment variable changes
NA
Pre-deployment activity
NA
Post-deployment activity
NA
API changes
Possible Issues in the future
NA