chore(nix): Build more crates in CI #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srid
force-pushed
the
nix-workspace
branch
2 times, most recently
from
cda704e to
1b3aa67
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mahatoankitkumar
approved these changes
Jul 12, 2024
|
Converting to draft, because there are a few more things left to fix since I just updated |
3 tasks
srid
force-pushed
the
nix-workspace
branch
2 times, most recently
from
40980a6 to
bf3bc70
Compare
srid
changed the title
rust-flake to simplify Nix in reporust-flake to simplify Nix in repo + Build all crates in Nix now
srid
changed the title
rust-flake to simplify Nix in repo + Build all crates in Nix now
srid
changed the title
srid
force-pushed
the
nix-workspace
branch
2 times, most recently
from
a4f5982 to
cc08e2b
Compare
Closed
Using https://github.com/juspay/rust-flake, we now build all crates that have binaries in the CI.
|
@Datron @mahatoankitkumar This is now ready for re-review and merge! It is an improvement over |
Datron
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses https://github.com/juspay/rust-flake to
superpositioncrate was being builtUses,