fix: Improve form inputs #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahatoankitkumar
requested review from
sauraww and
Datron
and removed request for
a team
mahatoankitkumar
force-pushed
the
fix/improve/form/inputs-new
branch
from
31d6199 to
f751edc
Compare
mahatoankitkumar
force-pushed
the
fix/improve/form/inputs-new
branch
from
f751edc to
6eae817
Compare
pratikmishra356
approved these changes
Jul 15, 2024
sauraww
requested changes
Jul 15, 2024
| class="input input-bordered w-full max-w-md" | ||
| value=config_value.get() | ||
| on:change=move |ev| { | ||
| logging::log!("{:?}", event_target_value(& ev)); |
There was a problem hiding this comment.
Can you add the desciption for the log here ?
| placeholder="Value" | ||
| class="input input-bordered w-full max-w-md pt-3" | ||
| on:change=move |ev| { | ||
| logging::log!("{:?}", event_target_value(& ev)); |
sauraww
requested changes
Jul 15, 2024
| #[prop(default = String::new())] class: String, | ||
| #[prop(default = false)] disabled: bool, | ||
| ) -> impl IntoView { | ||
| let (value, set_value) = create_signal(config_value.replace("\\", "")); |
There was a problem hiding this comment.
Can we avoid replacing it ?
What if someone actually wants to send this in the input ?
sauraww
requested changes
Jul 15, 2024
| on:change=move |ev| { | ||
| logging::log!("{:?}", event_target_value(&ev).parse::<u32>()); | ||
| logging::log!("{:?}", event_target_value(& ev).parse::< u32 > ()); |
There was a problem hiding this comment.
Can you add the log description here as well ?
sauraww
previously requested changes
Jul 15, 2024
| if schema.contains_key("enum") { | ||
| String::from("ENUM") | ||
| } else { | ||
| match schema.get("type").unwrap_or(&Value::Null) { |
There was a problem hiding this comment.
Why are we using unwrap and match both here ?
Possible to change it to :
match schema.get("type") { Some(Value::String(str_)) => str_.to_ascii_uppercase(), _ => String::from("STRING"), }
Datron
dismissed
sauraww’s stale review
Moving forward, anything missing can be addressed in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Better form fields
Screen.Recording.2024-07-12.at.12.16.37.PM.mov