Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat #396 : Create Experiments From Overrides #397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuvrajjsingh0
Copy link

Problem

Create Experiments From Overrides

Solution

Added create experiment popup to overrides

@yuvrajjsingh0 yuvrajjsingh0 requested a review from a team as a code owner January 30, 2025 12:20
}
>

<EditorProvider>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhranshuSanjeev shouldn't this Provider be already present inside the Forms itself

Copy link
Collaborator

@ayushjain17 ayushjain17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the commit action, squash the commits as well
also, files are not formatted correctly

@yuvrajjsingh0 yuvrajjsingh0 changed the title close #396 : Create Experiments From Overrides feat #396 : Create Experiments From Overrides Jan 30, 2025
@yuvrajjsingh0 yuvrajjsingh0 force-pushed the create-experiments-from-overrides branch 2 times, most recently from 733caf4 to 76e3430 Compare January 30, 2025 18:14
@mahatoankitkumar
Copy link
Collaborator

@yuvrajjsingh0 Can you please attach a video for this?

Copy link
Collaborator

@ayushjain17 ayushjain17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the commit action specifically as "feat: <<Commit Message>>"

@yuvrajjsingh0
Copy link
Author

Video:

Screen.Recording.2025-02-03.at.11.58.17.AM.mov

@Datron Datron linked an issue Feb 5, 2025 that may be closed by this pull request
@Datron Datron added the P0 label Feb 6, 2025
@Datron Datron requested a review from ayushjain17 February 7, 2025 10:17
@yuvrajjsingh0 yuvrajjsingh0 force-pushed the create-experiments-from-overrides branch from 95fd04c to ee07907 Compare February 13, 2025 10:50
@Datron Datron force-pushed the create-experiments-from-overrides branch from ee07907 to 5778bf9 Compare February 19, 2025 12:55
@yuvrajjsingh0 yuvrajjsingh0 force-pushed the create-experiments-from-overrides branch from 58b5fef to 95a0caf Compare February 25, 2025 09:26
@Datron
Copy link
Collaborator

Datron commented Feb 25, 2025

@yuvrajjsingh0 can you make one more quick change here? When the experiment is created, you get an experiment ID. Using this, you can redirect a user to the single experiments page after they have created an experiment from the override.

@yuvrajjsingh0 yuvrajjsingh0 force-pushed the create-experiments-from-overrides branch from ddff41d to cc96e92 Compare February 25, 2025 10:58
@yuvrajjsingh0
Copy link
Author

@yuvrajjsingh0 can you make one more quick change here? When the experiment is created, you get an experiment ID. Using this, you can redirect a user to the single experiments page after they have created an experiment from the override.

Done

@yuvrajjsingh0 yuvrajjsingh0 force-pushed the create-experiments-from-overrides branch from de28c17 to b393884 Compare February 25, 2025 11:02
@yuvrajjsingh0 yuvrajjsingh0 force-pushed the create-experiments-from-overrides branch from 7f191b2 to 27b04a8 Compare February 25, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Experiments From Overrides
5 participants