fix: removed err as a default value for schema type and enum variants #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datron
reviewed
Feb 20, 2025
Comment on lines
+61
to
+68
| let schema_type_s = Signal::derive(move || { | ||
| SchemaType::try_from(config_schema_rs.get()) | ||
| .map_err(|err| format!("Failed to get schema type: {}", err)) | ||
| }); | ||
| let enum_variants_s = Signal::derive(move || { | ||
| EnumVariants::try_from(config_schema_rs.get()) | ||
| .map_err(|err| format!("Failed to get enum variants: {}", err)) | ||
| }); |
There was a problem hiding this comment.
So these signals are read-only?
Datron
approved these changes
Feb 20, 2025
ShubhranshuSanjeev
force-pushed
the
fix/default-value-autofill
branch
from
1b7dd87 to
c89ddac
Compare
Comment on lines
+312
to
+333
| if schema_type.is_err() || enum_variants.is_err() { | ||
| let tooltip_txt = if config_schema_rs.get().is_null() { | ||
| "Please select a schema type".to_string() | ||
| } else { | ||
| schema_type_s.get().unwrap_err() | ||
| }; | ||
| return view! { | ||
| <div class="form-control"> | ||
| <label class="label"> | ||
| <span class="label-text">Default Value</span> | ||
| </label> | ||
| <div class="tooltip text-left w-full max-w-md" data-tip=tooltip_txt> | ||
| <textarea | ||
| type="text" | ||
| placeholder="Value" | ||
| class="input input-bordered w-full pt-3" | ||
| disabled=true | ||
| > | ||
| {config_value_rs.get().html_display()} | ||
| </textarea> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Rendering a disabled field until SchemaType is figured out for the default config.
mahatoankitkumar
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the problem you are trying to solve here
Solution
Provide a brief summary of your solution so that reviewers can understand your code
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change