feat: Added support for completions in monaco editor. #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ShreyBana
commented
Feb 25, 2025
•
ShreyBana
commented
- Monaco input type now accepts a vector of json values to be used for completions.
- Added JS-FFI(via wasm-bindgen) to create a monaco completions object. This is required as we have to call another JS-FFI to register this object, and that FFI itself accepts a foreign JS type, so needed to write the constructor in JS.
- Completions get registered on render & cleaned up on de-render.
ayushjain17
reviewed
Feb 25, 2025
Comment on lines
65
to
70
| if let Some(idp) = set_monaco_suggestions(language.to_string().as_str(), &suggestions) | ||
| { | ||
| on_cleanup(move || idp.dispose()); | ||
| } |
There was a problem hiding this comment.
most likely its not formatted
- Monaco input type now accepts a vector of json values to be used for completions. - Added JS-FFI(via wasm-bindgen) to create monaco completions object. This is required as we have to call another JS-FFI to register this object, and that FFI itself accepts a foreign JS type, so needed to write the constructor in JS. - Completions get registered on render & cleaned up on de-render.
ShreyBana
force-pushed
the
feat/ui/in-enum-completion
branch
from
205f2a3 to
bd3f00d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.