Rework async library in CAC client #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datron
force-pushed
the
fix-client-locking
branch
from
592d6d6 to
1f98d69
Compare
Datron
force-pushed
the
fix-client-locking
branch
from
1f98d69 to
2d74390
Compare
Datron
force-pushed
the
fix-client-locking
branch
from
2d74390 to
4feaccd
Compare
Datron
force-pushed
the
fix-client-locking
branch
from
4feaccd to
307135a
Compare
ShubhranshuSanjeev
approved these changes
Jun 21, 2024
SanchithHegde
approved these changes
Jun 21, 2024
mahatoankitkumar
approved these changes
Jun 24, 2024
Datron
added a commit
that referenced
this pull request
Jun 24, 2024
* feat: improve clients locking and handling in FFI * chore: add example integrations that help with testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Clippy while analyzing CAC client shows a error for calling await on a MutexGuard. This happens when we use the standard library RwLock.
Solution
Use tokio RwLock that handles this and is better at concurrent and parallel processing. Also add an integration example for cac client that lets implementers test out features of the client