Multiple "--header" arguments suppport #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify Deployment so that args.header can be an array or string. * Modify Deployment so the entire --header argument is quoted. * Modify Secret so it is also created if ".Values.credentials" is defined Sponsored-by: Orro Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I hope you're having a great day.
In order to connect to our Chisel server, the client must include two headers in their request before they can get past the edge security service we use. To achieve this, and to fix a couple of minor quirks that might be specific to my deployment, I have modified your fine helm chart in the following ways:
I don't expect any of these changes will impact any existing deployments.
Cheers.
Shaun.
Sponsored-by: Orro Group