[pull] main from webrecorder:main#218
Merged
pull[bot] merged 3 commits intojustarmadillo:mainfrom Mar 19, 2026
Merged
Conversation
- track 'directFetch' bool, not async loading on the state - call pageFinished() when direct fetch is finished - add check in pageFinished() to allow fromDirectFetch or regular page finished - don't reset the directFetch bool after calling pageFinished - fixes #995
- fixes #997 - move removing existing crawl dir before disk space check, in case clearing existing crawls frees up more space - also removes existing crawl dir before creating dirs - tests: overwrite tests were named incorrectly and were not running, rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )