Skip to content

Commit

Permalink
Bump the xunit group with 1 update (#1268)
Browse files Browse the repository at this point in the history
* Bump the xunit group with 1 update

Bumps the xunit group with 1 update: [xunit](https://github.com/xunit/xunit).

- [Commits](xunit/xunit@2.5.3...2.6.0)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: xunit
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix tests

Fix ambiguity between `Task` and `ValueTask` overloads.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: martincostello <[email protected]>
  • Loading branch information
dependabot[bot] and martincostello authored Nov 1, 2023
1 parent 875998c commit fa6a684
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<PackageVersion Include="SerilogTimings" Version="3.0.1" />
<PackageVersion Include="Shouldly" Version="4.2.1" />
<PackageVersion Include="Swashbuckle.AspNetCore" Version="6.5.0" />
<PackageVersion Include="xunit" Version="2.5.3" />
<PackageVersion Include="xunit" Version="2.6.0" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.5.3" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ public async Task Messages_Not_Dispatched_After_Cancellation()

cts.CancelAfter(_timeoutPeriod);

await Assert.ThrowsAnyAsync<OperationCanceledException>(async () => await runTask);
await Assert.ThrowsAnyAsync<OperationCanceledException>(() => runTask);

dispatchedBeforeCancelled.ShouldBeGreaterThan(0);
dispatchedAfterCancelled.ShouldBe(0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ public void Cannot_Add_Invalid_Reader()
}

[Fact]
public void Cannot_Get_Messages_Before_Started()
public async Task Cannot_Get_Messages_Before_Started()
{
// Arrange
using var multiplexer = new MergingMultiplexer(10, _outputHelper.ToLogger<MergingMultiplexer>());

// Act and Assert
Assert.ThrowsAsync<InvalidOperationException>(async () => await ReadAllMessages(multiplexer));
await Assert.ThrowsAsync<InvalidOperationException>(() => ReadAllMessages(multiplexer));
}

[Fact]
Expand Down Expand Up @@ -119,4 +119,4 @@ private static async Task ReadAllMessages(IMultiplexer multiplexer)
{
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,17 @@ public async Task Can_Integrate_With_Polly_Policies_Async()
new PollyMiddleware<string, int>(pollyPolicy));

var calledCount = 0;
await Assert.ThrowsAsync<CustomException>(async () => await policy.RunAsync("context", ct =>
await Assert.ThrowsAsync<CustomException>(() => policy.RunAsync("context", ct =>
{
calledCount++;
throw new CustomException();
}, CancellationToken.None));
await Assert.ThrowsAsync<CustomException>(async () => await policy.RunAsync("context", ct =>
await Assert.ThrowsAsync<CustomException>(() => policy.RunAsync("context", ct =>
{
calledCount++;
throw new CustomException();
}, CancellationToken.None));
await Assert.ThrowsAsync<BrokenCircuitException>(async () => await policy.RunAsync("context", ct =>
await Assert.ThrowsAsync<BrokenCircuitException>(() => policy.RunAsync("context", ct =>
{
calledCount++;
throw new CustomException();
Expand All @@ -88,4 +88,4 @@ public CustomException()
{
}
}
}
}

0 comments on commit fa6a684

Please sign in to comment.