This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Fix: check environment Gzip option #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I found that |
Strech
force-pushed
the
fix/gzip-option
branch
2 times, most recently
from
f774b2e
to
94d7d99
Compare
Skip gzip compression if it's disabled in Rails env.
Since we already have Rails env in requirejs.env it doesn't make any sense to call file_digest from Rails
|
@carsomyr Hi, can you have a look on this PR? |
|
👍 |
|
Hey @scudelletti -- apologies, but I'm no longer actively working on the project that uses this and have been out of touch on recent changes. @jwhitley or @carsomyr will have to reply. |
|
Thanks for the reply @billmag we will wait for them. |
|
Sorry, I'm not much immediate help either. @carsomyr has been the active maintainer of this project for years now; I'm very out of touch. However, I'm happy to help get some additional maintainer assistance in place if life's pulled Roy in other directions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the sprockets you can disable gzipping your assets, but requirejs-rails ignore this option.
The second commit change Sprockets env call to the defined variable, instead of new
::Rails.application.assetscall.