Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving closed notations at level 0 in anticipation of the removal of the Coq fallback ignoring levels when nothing else applies. #134

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

herbelin
Copy link
Contributor

Hi, as indicated in the title, this PR is in anticipation of a change of Coq's parsing rules (see e.g. coq/coq#17876 for details). For instance, Δ( c ), formerly at level 90, was used on the right of↓, which was expecting a notation at level less than 90. As another example, ⟨πD,πC⟩, formerly at level 100, was used as argument of ◯, as if it were at level less than 40.

So, the PR moves to level 0 the notations that have terminals on both sides (in general, there is little to gain not to do so, the only problem being if the starting symbol is also ending another notation).

There is another small change, requiring extra parentheses in the argument of the prefix notations `1 and `2.

If you agree with the change, this can be merged without delays.

@jwiegley
Copy link
Owner

jwiegley commented Nov 5, 2023

This looks good to me, I will merge once CI passes.

@jwiegley jwiegley merged commit cdf5afc into jwiegley:master Nov 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants