Update README.md example consistent w/text #1087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a double-triple negation going on in the related statement in the documentation This example in supposed to use `when` to show how to *prevent* `ensure` from happening on mac systems. So the idea is to make that code block conditionally execute, and it should _not_ execute if the system is a mac, (thereby side-stepping the `ensure`). Is this all correct? I'm not entirely sure that this is now a *sensible* example, and I would want to write this as an `unless` instead, but I think this is as a first step consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a double-triple negation going on in the related statement in the documentation
This example in supposed to use
whento show how to preventensurefrom happening on mac systems. So the idea is to make that code block conditionally execute, and it should not execute if the system is a mac, (thereby side-stepping theensure).Is this all correct?
I'm not entirely sure that this is now a sensible example, and I would want to write this as an
unlessinstead, but I think this is as a first step consistent.