-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect ESPN ID for Georgia Tech #116
Conversation
Regenerated records for seasons ND played Georgia Tech (but only back to when we already had records)
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces several modifications across multiple JSON files representing sports schedules and team data. For the 2006 and 2007 schedules, the primary changes include the removal of the "rankings" field from game entries in 2006 and updates to team records in both years. The 2006 data reflects adjustments to the home and away team records based on game outcomes, while the 2007 data includes the addition of rankings for both home and away teams in various games. In the 2015 schedule, new "rankings" fields were added for multiple game entries, enhancing the detail of team standings. The 2020 schedule saw the removal of rankings for several games while adding them back for specific matchups, affecting data interpretation. The 2021 schedule updates included significant changes to the away team's records in the last game, along with new attributes indicating bowl game status and coaching staff changes. Finally, the 2024 schedule features updates to team records across multiple games, ensuring accurate performance metrics. Additionally, the Sequence Diagram(s)sequenceDiagram
participant User
participant JSONFile
participant Database
User->>JSONFile: Request schedule data
JSONFile->>Database: Retrieve schedule data
Database-->>JSONFile: Return schedule data
JSONFile-->>User: Send schedule data
User->>JSONFile: Request team data
JSONFile->>Database: Retrieve team data
Database-->>JSONFile: Return team data
JSONFile-->>User: Send team data
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Visit the preview URL for this PR (updated for commit 0bfa233): https://notreda-me--pr116-jw-fix-gt-espn-id-70ty18h2.web.app (expires Sun, 10 Nov 2024 05:17:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 3b43555253229bfc8170ad9b1b10c08174cc11a3 |
Regenerated records for seasons ND played Georgia Tech (but only back to when we already had records)
Summary by CodeRabbit
New Features
Bug Fixes
Chores