Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect ESPN ID for Georgia Tech #116

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

jwngr
Copy link
Owner

@jwngr jwngr commented Nov 3, 2024

Regenerated records for seasons ND played Georgia Tech (but only back to when we already had records)

Summary by CodeRabbit

  • New Features

    • Updated game schedules for the years 2006, 2007, 2015, 2020, 2021, 2024, and teams data for 2024.
    • Added rankings for several games in the 2007 and 2015 schedules, enhancing detail on team performance.
    • Introduced new attributes for bowl games in 2021, including the nickname and game type.
  • Bug Fixes

    • Corrected team records across multiple seasons to reflect accurate performance metrics.
  • Chores

    • Updated the ESPN ID for the "Georgia Tech" team to ensure accurate data retrieval.

Regenerated records for seasons ND played Georgia Tech (but only back to when we already had records)
Copy link

coderabbitai bot commented Nov 3, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications across multiple JSON files representing sports schedules and team data. For the 2006 and 2007 schedules, the primary changes include the removal of the "rankings" field from game entries in 2006 and updates to team records in both years. The 2006 data reflects adjustments to the home and away team records based on game outcomes, while the 2007 data includes the addition of rankings for both home and away teams in various games.

In the 2015 schedule, new "rankings" fields were added for multiple game entries, enhancing the detail of team standings. The 2020 schedule saw the removal of rankings for several games while adding them back for specific matchups, affecting data interpretation. The 2021 schedule updates included significant changes to the away team's records in the last game, along with new attributes indicating bowl game status and coaching staff changes. Finally, the 2024 schedule features updates to team records across multiple games, ensuring accurate performance metrics. Additionally, the teams.json file includes a singular change to the espnId for the "Georgia Tech" team.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant JSONFile
    participant Database

    User->>JSONFile: Request schedule data
    JSONFile->>Database: Retrieve schedule data
    Database-->>JSONFile: Return schedule data
    JSONFile-->>User: Send schedule data

    User->>JSONFile: Request team data
    JSONFile->>Database: Retrieve team data
    Database-->>JSONFile: Return team data
    JSONFile-->>User: Send team data
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Nov 3, 2024

Visit the preview URL for this PR (updated for commit 0bfa233):

https://notreda-me--pr116-jw-fix-gt-espn-id-70ty18h2.web.app

(expires Sun, 10 Nov 2024 05:17:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3b43555253229bfc8170ad9b1b10c08174cc11a3

@jwngr jwngr merged commit 6decbe4 into master Nov 3, 2024
6 of 7 checks passed
@jwngr jwngr deleted the jw-fix-gt-espn-id branch November 3, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant