Added Army 2024 results #125
Conversation
WalkthroughThe changes in the pull request involve updates to two JSON files related to college football for the 2024 season. In In Sequence Diagram(s)sequenceDiagram
participant User
participant PollsData
participant SchedulesData
User->>PollsData: Request college football rankings
PollsData->>User: Return updated rankings and records
User->>SchedulesData: Request game schedule
SchedulesData->>User: Return updated game schedule with statistics
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 144c2f3): https://notreda-me--pr125-jw-army-2024-w4nd3qxq.web.app (expires Sun, 01 Dec 2024 20:21:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 3b43555253229bfc8170ad9b1b10c08174cc11a3 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
website/src/resources/schedules/2024.json (1)
Line range hint
896-977: Critical: Fix inconsistencies in the Army game entrySeveral inconsistencies were found in the Army game data:
- The game result is marked as "L" (line 977) but the score shows a home team victory (49-14).
- The records and result appear inconsistent:
- Notre Dame's record shows 10-1 despite being marked as a loss
- Army's record shows 9-1 despite being marked as a win
Apply this diff to fix the result:
- "result": "L", + "result": "W",data/polls/2024.json (1)
Line range hint
654-784: Fix malformed team name for UNLV.There's a copy-paste error in the team name that includes CSS styles:
".mw-parser-output .plainlist ol,.mw-parser-output .plainlist ul{line-height:inherit;list-style:none;margin:0;padding:0}.mw-parser-output .plainlist ol li,.mw-parser-output .plainlist ul li{margin-bottom:0}UNLV"This should be simply "UNLV".
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
data/polls/2024.json(20 hunks)website/src/resources/schedules/2024.json(10 hunks)
🔇 Additional comments (4)
website/src/resources/schedules/2024.json (2)
Line range hint 991-1018: LGTM: USC game updates are consistent
The updates to the USC game entry, including coverage, records, and rankings, are consistent with the season progression.
Line range hint 1-1018: LGTM: Overall data consistency
The progression of rankings and records throughout the season is logical and consistent, accurately reflecting the team's performance across all games.
data/polls/2024.json (2)
Line range hint 914-3642: LGTM: Army's progression is accurately tracked.
Army's rankings and record progression is consistent and well-documented:
- First ranked appearance: Simplified
/commoncomponent file structure #23 (6-0) on Oct 12 - Peak ranking: Added source maps and fixed
npm run analyzecommand #16 (9-0) on Nov 10 - Final ranking: Replaced giant
schedule.jsonfile with individual season files #22 (9-1) on Nov 24, reflecting their first loss of the season
134-134: Verify the poll release date changes.
Multiple dates have been shifted one day earlier (e.g., from Tuesday to Monday). Please confirm if this aligns with the official poll release schedule for 2024.
Also applies to: 264-264, 394-394, 524-524, 654-654, 784-784, 914-914, 1044-1044, 1174-1174
✅ Verification successful
Poll release dates follow a consistent pattern and align with standard schedules
The dates in the file follow the expected pattern for college football poll releases:
- First poll on Monday, September 2nd (Labor Day)
- Regular season polls on Saturdays/Sundays
- Consistent weekly cadence throughout the season
All dates align with typical poll release schedules, where AP and Coaches polls are released on Sundays (or Monday for week 1).
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the new dates align with typical poll release days
# Expected: Dates should fall on typical poll release days (Sunday/Monday)
# Extract and display all dates for verification
echo "AP Poll dates:"
grep -A 1 '"date": "2024' data/polls/2024.json | grep "date" | sort | uniq
echo "Coaches Poll dates:"
grep -A 1 '"date": "2024' data/polls/2024.json | grep "date" | sort | uniq
Length of output: 965
Summary by CodeRabbit
New Features
Bug Fixes