Add RsaOaep256 algorithm #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @grantpaulson6, thanks for the addition. Looks like the algorithm is not supported by all the openssl/Ruby versions this gem supports. In this case there could be some conditionals to require this algorithm. |
grantpaulson6
force-pushed
the
add_RsaOaep256_alg
branch
from
9ee9e11 to
d448fca
Compare
grantpaulson6
force-pushed
the
add_RsaOaep256_alg
branch
from
d448fca to
d1be0e1
Compare
|
@anakinj hows this look? Rubocop error seems unrelated |
|
Oh. Sorry for the silence. Been vacationing, i'll take a look at this at some point. The Linting error for sure looks unrelated. |
|
Thanks for the addition @grantpaulson6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the RsaOaep256 algorithm