added timeLimit to search query. #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added timeLimit with a default that matches ldapjs to not break backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added timeLimit with a default that matches ldapjs to not break backwards compatibility
Using this package we were seeing timeLimit errors and I didnt find a good way to pass a timelimit from simple-ldap-search to the ldapjs module.
We take in the timeLimit into the search function as a default paramter that matches the timeout of ldapjs: http://ldapjs.org/client.html#search
We then add timeLimit back to the opts variable with filter and attributes parameters.